chore: adding 'Load this SAE' popup to docs table #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanind
commented
Nov 7, 2024
| # The below three make MathJax work, see https://squidfunk.github.io/mkdocs-material/reference/mathjax/ | ||
| - javascript/mathjax.js | ||
| - https://polyfill.io/v3/polyfill.min.js?features=es6 |
There was a problem hiding this comment.
These JS files don't exist and are erroring on load on the docs website, so just removing / commenting for now
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #362 +/- ##
=======================================
Coverage 66.14% 66.14%
=======================================
Files 25 25
Lines 3373 3373
Branches 432 432
=======================================
Hits 2231 2231
Misses 1021 1021
Partials 121 121 ☔ View full report in Codecov by Sentry. |
|
discussed / approved offline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've noticed users sometimes get confused on the pretrained SAE table docs page about how to load a specific SAE in their code. This PR adds a "Load this SAE" link to each SAE in the pretrained SAEs table in docs. Clicking this link will pop up the code to load the specific SAE in SAELens, with a "Copy code" button to make it easy to copy into your own work.
The JS/CSS is a bit hacky but should do the job.
Type of change
Please delete options that are not relevant.
Checklist: